fix: Make calc_sort_timestamp() a continuous function of message timestamp and improve its performance
#7180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
2 times, most recently
from
a7ef844 to
fe2e94c
Compare
iequidoo
changed the base branch from
iequidoo/test_sync_sentbox_then_inbox
to
main
iequidoo
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
3 times, most recently
from
295215c to
f05e585
Compare
iequidoo
changed the title
calc_sort_timestamp() a continuous function of message timestampcalc_sort_timestamp() a continuous function of message timestamp and improve its performance
iequidoo
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
from
f05e585 to
462985d
Compare
iequidoo
commented
Sep 10, 2025
| Msg#13: info (Contact#Contact#Info): alice@example.org invited you to join this group. | ||
|
|
||
| Waiting for the device of alice@example.org to reply… [NOTICED][INFO] | ||
| Msg#15: info (Contact#Contact#Info): alice@example.org replied, waiting for being added to the group… [NOTICED][INFO] |
There was a problem hiding this comment.
This reply is already encrypted, so now the message order looks more correct as to me. If an old delayed message arrives, even if it's outgoing, e.g. from another device, it also will be sorted correctly
link2xt
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
from
462985d to
7c44f7d
Compare
link2xt
force-pushed
the
link2xt/ykltkokxntvk
branch
from
66bffdb to
0f94529
Compare
…mestamp This also simplifies the SQL query in `calc_sort_timestamp()` and prepares for creation of a db index for it so that it's fast. Currently it doesn't uses indexes effectively; if a chat has many messages, it's slow, i.e. O(n). This as well fixes ordering of delayed encrypted outgoing messages; before, they could be sorted above "Messages are end-to-end encrypted."
Tested on some random chat, the SQL query took 1.411202ms (vs 6.692714ms before) in median. Still looks a bit slow, but already better.
link2xt
force-pushed
the
link2xt/ykltkokxntvk
branch
from
0f94529 to
5051240
Compare
link2xt
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
from
7c44f7d to
dce6e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7116